diff --git a/common.gypi b/common.gypi index e4ef01a0007119..87a84afa4494c6 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.21', + 'v8_embedder_string': '-node.23', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/BUILD.gn b/deps/v8/BUILD.gn index a026749a31db52..90ec4097d7a2b8 100644 --- a/deps/v8/BUILD.gn +++ b/deps/v8/BUILD.gn @@ -895,6 +895,8 @@ action("postmortem-metadata") { "src/objects/code.h", "src/objects/data-handler.h", "src/objects/data-handler-inl.h", + "src/objects/descriptor-array.h", + "src/objects/descriptor-array-inl.h", "src/objects/feedback-cell.h", "src/objects/feedback-cell-inl.h", "src/objects/fixed-array-inl.h", diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py index ceaf7798fd32c2..021a2f2c100263 100644 --- a/deps/v8/tools/gen-postmortem-metadata.py +++ b/deps/v8/tools/gen-postmortem-metadata.py @@ -230,15 +230,6 @@ { 'name': 'class_SharedFunctionInfo__function_data__Object', 'value': 'SharedFunctionInfo::kFunctionDataOffset' }, - - { 'name': 'class_ConsString__first_offset__int', - 'value': 'ConsString::kFirstOffset' }, - { 'name': 'class_ConsString__second_offset__int', - 'value': 'ConsString::kSecondOffset' }, - { 'name': 'class_SlicedString__offset_offset__int', - 'value': 'SlicedString::kOffsetOffset' }, - { 'name': 'class_ThinString__actual_offset__int', - 'value': 'ThinString::kActualOffset' }, ]; # @@ -286,6 +277,12 @@ 'Code, instruction_start, uintptr_t, kHeaderSize', 'Code, instruction_size, int, kInstructionSizeOffset', 'String, length, int32_t, kLengthOffset', + 'DescriptorArray, header_size, uintptr_t, kHeaderSize', + 'ConsString, first, String, kFirstOffset', + 'ConsString, second, String, kSecondOffset', + 'SlicedString, offset, SMI, kOffsetOffset', + 'ThinString, actual, String, kActualOffset', + 'Symbol, name, Object, kNameOffset', ]; # @@ -296,7 +293,8 @@ expected_classes = [ 'ConsString', 'FixedArray', 'HeapNumber', 'JSArray', 'JSFunction', 'JSObject', 'JSRegExp', 'JSPrimitiveWrapper', 'Map', 'Oddball', 'Script', - 'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo', 'JSPromise' + 'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo', 'JSPromise', + 'DescriptorArray' ]; diff --git a/src/v8abbr.h b/src/v8abbr.h index 247094c408b3cc..3cfcb37c907f61 100644 --- a/src/v8abbr.h +++ b/src/v8abbr.h @@ -104,9 +104,9 @@ #define V8_OFF_STR_CHARS \ V8_OFF_HEAP(V8DBG_CLASS_SEQONEBYTESTRING__CHARS__CHAR) #define V8_OFF_CONSSTR_CAR \ - V8_OFF_HEAP(V8DBG_CLASS_CONSSTRING__FIRST_OFFSET__INT) + V8_OFF_HEAP(V8DBG_CLASS_CONSSTRING__FIRST__STRING) #define V8_OFF_CONSSTR_CDR \ - V8_OFF_HEAP(V8DBG_CLASS_CONSSTRING__SECOND_OFFSET__INT) + V8_OFF_HEAP(V8DBG_CLASS_CONSSTRING__SECOND__STRING) #define V8_OFF_EXTSTR_RSRC \ V8_OFF_HEAP(V8DBG_CLASS_EXTERNALSTRING__RESOURCE__OBJECT) #define V8_OFF_FA_SIZE \ diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index 4a0667a97f9d00..790d0dbb5c29b5 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -62,8 +62,8 @@ function getExpectedSymbols() { 'v8dbg_bit_field3_number_of_own_descriptors_shift', 'v8dbg_class_Code__instruction_size__int', 'v8dbg_class_Code__instruction_start__uintptr_t', - 'v8dbg_class_ConsString__first_offset__int', - 'v8dbg_class_ConsString__second_offset__int', + 'v8dbg_class_ConsString__first__String', + 'v8dbg_class_ConsString__second__String', 'v8dbg_class_FixedArray__data__uintptr_t', 'v8dbg_class_FixedArrayBase__length__SMI', 'v8dbg_class_JSTypedArray__base_pointer__Object', @@ -104,10 +104,10 @@ function getExpectedSymbols() { 'v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object', 'v8dbg_class_SharedFunctionInfo__script_or_debug_info__Object', 'v8dbg_class_UncompiledData__start_position__int32_t', - 'v8dbg_class_SlicedString__offset_offset__int', + 'v8dbg_class_SlicedString__offset__SMI', 'v8dbg_class_SlicedString__parent__String', 'v8dbg_class_String__length__int32_t', - 'v8dbg_class_ThinString__actual_offset__int', + 'v8dbg_class_ThinString__actual__String', 'v8dbg_context_idx_scope_info', 'v8dbg_context_idx_prev', 'v8dbg_context_min_slots',