Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick a4545db74e52 #31127

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick a4545db74e52 #31127

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

Fix library process mapping for FreeBSD.

Refs: v8/v8@a4545db

Original commit message :

FreeBSD update of process library mapping listing.
Not best to rely on /proc presence basically when
the linux compatibily layer is enabled so
going through more programmatically.

Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65442}

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Dec 29, 2019
@devnexen devnexen requested a review from targos December 29, 2019 12:57
@cjihrig
Copy link
Contributor

cjihrig commented Dec 29, 2019

Should this bump v8_embedder_string in common.gypi?

@targos
Copy link
Member

targos commented Dec 29, 2019

Could you use the git node v8 backport command? It should generate a more precise commit message and bump the embedder string

gengjiawen
gengjiawen requested changes Dec 29, 2019
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like related v8 file is missing.

@devnexen
deps: V8: backport a4545db
232ee8b 
Original commit message:

    FreeBSD update of process library mapping listing.

    Not best to rely on /proc presence basically when
    the linux compatibily layer is enabled so
    going through more programmatically.

    Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65442}

Refs: v8/v8@a4545db
@BridgeAR BridgeAR added the freebsd Issues and PRs related to the FreeBSD platform. label Jan 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 2, 2020 •
edited by BridgeAR

CI: https://ci.nodejs.org/job/node-test-pull-request/28099/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2757/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2020
@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

The embedder string should be updated again while landing.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28131/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28151/

BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@devnexen @BridgeAR
deps: V8: backport a4545db
866d0cd 
Original commit message:

    FreeBSD update of process library mapping listing.

    Not best to rely on /proc presence basically when
    the linux compatibily layer is enabled so
    going through more programmatically.

    Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65442}

PR-URL: #31127
Refs: v8/v8@a4545db
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR
Copy link
Member

BridgeAR commented Jan 3, 2020 •
edited

Landed in 866d0cd 🎉
Landed in d6a2bad 🎉

@BridgeAR BridgeAR closed this Jan 3, 2020
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@devnexen @BridgeAR
deps: V8: backport a4545db
d6a2bad 
Original commit message:

    FreeBSD update of process library mapping listing.

    Not best to rely on /proc presence basically when
    the linux compatibily layer is enabled so
    going through more programmatically.

    Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65442}

PR-URL: #31127
Refs: v8/v8@a4545db
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@devnexen @BridgeAR
deps: V8: backport a4545db
ca23511 
Original commit message:

    FreeBSD update of process library mapping listing.

    Not best to rely on /proc presence basically when
    the linux compatibily layer is enabled so
    going through more programmatically.

    Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65442}

PR-URL: #31127
Refs: v8/v8@a4545db
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@devnexen @targos
deps: V8: backport a4545db
d905d04 
Original commit message:

    FreeBSD update of process library mapping listing.

    Not best to rely on /proc presence basically when
    the linux compatibily layer is enabled so
    going through more programmatically.

    Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65442}

PR-URL: #31127
Refs: v8/v8@a4545db
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@devnexen @BethGriggs
deps: V8: backport a4545db
2501982 
Original commit message:

    FreeBSD update of process library mapping listing.

    Not best to rely on /proc presence basically when
    the linux compatibily layer is enabled so
    going through more programmatically.

    Change-Id: Ida4973f9da6dec6e9caa6e419f3612ec5ef95048
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710664
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65442}

PR-URL: #31127
Refs: v8/v8@a4545db
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. freebsd Issues and PRs related to the FreeBSD platform. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@devnexen @cjihrig @targos @nodejs-github-bot @BridgeAR @gengjiawen