Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: use let instead of var in crypto #31135

Closed
wants to merge 1 commit into from
Closed

benchmark: use let instead of var in crypto #31135

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Dec 30, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. labels Dec 30, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 1, 2020
@Trott
Copy link
Member

Trott commented Jan 1, 2020

I ran test/benchmark/test-benchmark-crypto.js locally with this change to confirm it didn't break anything. (That test isn't run in our regular CI, only nightly.)

@Trott
Copy link
Member

Trott commented Jan 1, 2020

Landed in 7365000

@Trott Trott closed this Jan 1, 2020
Trott pushed a commit that referenced this pull request Jan 1, 2020
@dnlup @Trott
benchmark: use let instead of var in crypto
7365000 
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@dnlup @BridgeAR
benchmark: use let instead of var in crypto
b193142 
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
@dnlup dnlup deleted the benchmark_crypto branch January 10, 2020 13:38
targos pushed a commit that referenced this pull request Jan 14, 2020
@dnlup @targos
benchmark: use let instead of var in crypto
d30911e 
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@dnlup @BethGriggs
benchmark: use let instead of var in crypto
1c97163 
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dnlup @Trott @BridgeAR @trivikr @nodejs-github-bot