util: improve unicode support #31319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
readline
BridgeAR
force-pushed
the
2020-01-11-util-better-unicode-support
branch
from
81735c6
to
02515e8
Compare
This comment has been minimized.
This comment has been minimized.
BridgeAR
force-pushed
the
2020-01-11-util-better-unicode-support
branch
from
02515e8
to
80fe23b
Compare
This comment has been minimized.
This comment has been minimized.
BridgeAR
force-pushed
the
2020-01-11-util-better-unicode-support
branch
from
da70f98
to
fc7f090
Compare
|
I'm not sure who to ping for a review. @srl295 maybe? |
jasnell
approved these changes
Jan 13, 2020
srl295
approved these changes
Jan 13, 2020
| const isFullWidthCodePoint = (code) => { | ||
| // Code points are partially derived from: | ||
| // http://www.unicode.org/Public/UNIDATA/EastAsianWidth.txt | ||
| return code >= 0x1100 && ( |
There was a problem hiding this comment.
So this might be doable as a regex… it could be compiled as a regex, i don't think there's an East Asian Width property available in regex.
There was a problem hiding this comment.
This could definitely be a regular expression. I guess it's slower that way but I did not check. I'll have a look soon.
There was a problem hiding this comment.
ICU4C also has API to get the East Asian Width.
There was a problem hiding this comment.
Yes, we use that in case Node.js is build with ICU but this is the fallback code.
Trott
approved these changes
Jan 14, 2020
JungMinu
approved these changes
Jan 16, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ).
BridgeAR
force-pushed
the
2020-01-11-util-better-unicode-support
branch
from
fc7f090
to
1b9547f
Compare
BridgeAR
added
the
author ready
|
Relevant test failures in the no-intl host on CI? |
Trott
removed
the
author ready
BridgeAR
added
the
author ready
BridgeAR
added a commit
that referenced
this pull request
Jan 22, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: #31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
|
Landed in 8fb5fe2 🎉 |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: #31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
|
@BridgeAR if this should go back to |
targos
removed
backport-requested-v12.x
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: nodejs#31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: #31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array grouping function relies on the width of the characters.
It was not calculated correct so far, since it used the string
length instead.
This improves the unicode output by calculating the mono-spaced
font width (other fonts might differ).
I had to move some functions. Otherwise we'd have to load the utils functions by default and that did not seem necessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes