build,src: remove sslv3 support #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Note that SSLv2 and SSLv3 are disallowed but SSLv2_method and friends are | ||
| // still accepted. They are OpenSSL's way of saying that all known protocols | ||
| // are supported unless explicitly disabled (which we do for SSLv2 and SSLv3.) | ||
| tls.createSecureContext({ secureProtocol: 'SSLv23_method' }); |
There was a problem hiding this comment.
var methods = []; methods.forEach(...)
There was a problem hiding this comment.
I like the explicitness. The url tests use (humongous!) arrays and when something breaks, it's always a pain to figure out what.
There was a problem hiding this comment.
agreed with @bnoordhuis
|
LGTM, but going to defer to @indutny |
SSLv3 is susceptible to downgrade attacks. Provide secure defaults, disable v3 protocol support entirely. PR-URL: nodejs#315 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
I'm fine with it, LGTM |
bnoordhuis
force-pushed
the
remove-sslv3-support
branch
from
7017247
to
5165d71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSLv3 is susceptible to downgrade attacks. Provide secure defaults,
disable v3 protocol support entirely.
R=@indutny, /cc @iojs/tc