n-api: fix comment on expected N-API version #32236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau
approved these changes
Mar 12, 2020
legendecas
approved these changes
Mar 13, 2020
lpinca
approved these changes
Mar 13, 2020
|
Doc only change, so travis ci run should be good enough. |
mhdawson
added a commit
that referenced
this pull request
Mar 16, 2020
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32236 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in e063ebd |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 19, 2020
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32236 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32236 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs#32236 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32236 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the comment about the expected version so
that it does not get out of sync. The code shows
the expected version anyway.
Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes