Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: throw error when duplicated exportNames in SyntheticModule #32810

Closed
wants to merge 1 commit into from
Closed

vm: throw error when duplicated exportNames in SyntheticModule #32810

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

Fixes: #32806

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label Apr 13, 2020
@himself65 himself65 requested a review from targos April 13, 2020 10:03
SimenB
SimenB reviewed Apr 13, 2020
View reviewed changes
lib/internal/vm/module.js Outdated Show resolved Hide resolved
@himself65

This comment has been minimized.

Sign in to view
targos
targos reviewed Apr 13, 2020
View reviewed changes
lib/internal/vm/module.js Outdated Show resolved Hide resolved
devsnek
devsnek reviewed Apr 13, 2020
View reviewed changes
lib/internal/vm/module.js Outdated Show resolved Hide resolved
lib/internal/vm/module.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30685/

@himself65 himself65 changed the title vm: avoid duplicated exportNames on SyntheticModule vm: throw error when duplicated exportNames in SyntheticModule Apr 13, 2020
SimenB
SimenB reviewed Apr 13, 2020
View reviewed changes
lib/internal/vm/module.js Outdated Show resolved Hide resolved
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31040/

himself65 added a commit that referenced this pull request Apr 28, 2020
@himself65
vm: throw error when duplicated exportNames in SyntheticModule
9545013 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@himself65
Copy link
Member Author

landed in 9545013

@himself65 himself65 closed this Apr 28, 2020
targos pushed a commit that referenced this pull request May 4, 2020
@himself65 @targos
vm: throw error when duplicated exportNames in SyntheticModule
4423304 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@himself65 @targos
vm: throw error when duplicated exportNames in SyntheticModule
8b4c57f 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@himself65 @targos
vm: throw error when duplicated exportNames in SyntheticModule
6a9f867 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB left review comments

@devsnek devsnek devsnek left review comments

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntheticModule aborts with illegal hardware instruction during linking
6 participants
@himself65 @nodejs-github-bot @addaleax @SimenB @targos @devsnek