lib: unnecessary const assignment for class #32962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking at the code we are using the FixedCircularBuffer as an internal implementation for FixedQueue and hence we do not need a const reference for initializing objects.
lpinca
approved these changes
Apr 21, 2020
jasnell
approved these changes
Apr 21, 2020
puzpuzpuz
approved these changes
Apr 24, 2020
puzpuzpuz
added
the
author ready
puzpuzpuz
pushed a commit
that referenced
this pull request
Apr 24, 2020
PR-URL: #32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
|
Landed in 0d7638e Thanks for this improvement! |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #32962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can avoid the const assignment as it is not needed for the
instantiating objects in the same file as the class is not exported
anywhere.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes