Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: Support for console constructor groupIndentation options #32964

Closed
wants to merge 3 commits into from
Closed

console: Support for console constructor groupIndentation options #32964

wants to merge 3 commits into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Apr 21, 2020

Provides groupIndentation options to support custom indentation.

fixes: #32947

/cc @BridgeAR

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Apr 21, 2020
BridgeAR
BridgeAR approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

doc/api/console.md Outdated Show resolved Hide resolved
doc/api/console.md Outdated Show resolved Hide resolved
@addaleax addaleax added semver-minor PRs that contain new features and should be released in the next minor version. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31035/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31052/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31073/

@rickyes
Copy link
Contributor Author

rickyes commented Apr 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31073/

A green build.

@addaleax
Copy link
Member

Landed in f68428b

@addaleax addaleax closed this Apr 29, 2020
addaleax pushed a commit that referenced this pull request Apr 29, 2020
@rickyes @addaleax
console: support console constructor groupIndentation option
f68428b 
PR-URL: #32964
Fixes: #32947
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes rickyes deleted the support-console-groupIndentation branch April 29, 2020 01:52
targos pushed a commit that referenced this pull request May 4, 2020
@rickyes @targos
console: support console constructor groupIndentation option
c49e3ea 
PR-URL: #32964
Fixes: #32947
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 4, 2020
Merged
targos added a commit that referenced this pull request May 5, 2020
@targos
2020-05-05, Version 14.2.0 (Current)
d68f78f 
Notable changes:

* Track function calls with `assert.CallTracker` (experimental).
  #31982
* Added a `groupIndentation` option to the `Console` constructor.
  #32964

PR-URL: #33232
targos added a commit that referenced this pull request May 5, 2020
@targos
2020-05-05, Version 14.2.0 (Current)
f446b20 
Notable changes:

* Track function calls with `assert.CallTracker` (experimental).
  #31982
* Added a `groupIndentation` option to the `Console` constructor.
  #32964

PR-URL: #33232
targos pushed a commit that referenced this pull request May 7, 2020
@rickyes @targos
console: support console constructor groupIndentation option
d288a52 
PR-URL: #32964
Fixes: #32947
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@rickyes @targos
console: support console constructor groupIndentation option
154b18f 
PR-URL: #32964
Fixes: #32947
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customizable console.group indentation
5 participants
@rickyes @nodejs-github-bot @addaleax @jasnell @BridgeAR