Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify when not to run CI on docs #33101

Closed
wants to merge 2 commits into from

Conversation

juanarbol
Copy link
Member

Collaborators won't need to run CI on documentation-only changes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Collaborators won't need to run CI on documentation-only changes.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 27, 2020
@juanarbol juanarbol requested a review from addaleax April 27, 2020 19:40
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Apr 29, 2020
@juanarbol juanarbol requested a review from Trott May 1, 2020 12:57
gireeshpunathil pushed a commit that referenced this pull request May 2, 2020
Collaborators won't need to run CI on documentation-only changes.

PR-URL: #33101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@gireeshpunathil
Copy link
Member

landed 26477b8

@juanarbol juanarbol deleted the juanarbol/runing-ci-docs branch May 2, 2020 22:17
targos pushed a commit that referenced this pull request May 4, 2020
Collaborators won't need to run CI on documentation-only changes.

PR-URL: #33101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@targos targos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
Collaborators won't need to run CI on documentation-only changes.

PR-URL: #33101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
targos pushed a commit that referenced this pull request May 13, 2020
Collaborators won't need to run CI on documentation-only changes.

PR-URL: #33101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants