lib: cosmetic change to builtinLibs list for maintainability #33106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31023/ (:yellow_heart:) |
devsnek
approved these changes
Apr 27, 2020
addaleax
approved these changes
Apr 27, 2020
jasnell
added
author ready
jasnell
added a commit
that referenced
this pull request
Apr 29, 2020
This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: #33106 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 80b9777 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: #33106 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: #33106 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: #33106 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a largely cosmetic change suggested for easier
maintainability of the builtinLibs list. While the
QUIC PR no longer modifies this list, the original version
of the PR did and the fact that all of the entries were
bundled up into the same lines meant that adding one
forced a larger change to all. With this PR, when we
want to add a new built-in, it won't impact any of the
others.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes