src: crypto_common edits #33107
Closed
src: crypto_common edits #33107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by: James M Snell <jasnell@gmail.com>
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there.
nodejs-github-bot
added
c++
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31024/ (:yellow_heart:) |
addaleax
approved these changes
Apr 27, 2020
sam-github
approved these changes
Apr 27, 2020
jasnell
added
the
author ready
jasnell
added a commit
that referenced
this pull request
Apr 29, 2020
Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
jasnell
added a commit
that referenced
this pull request
Apr 29, 2020
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the QUIC PR:
Commit 1: Updates UseSNIContext to use BaseObjectPtr
Commit 2: Returns Undefined when validation err == 0. This is currently only used by the QUIC implementation but the change itself is not QUIC specific.
/cc @addaleax @sam-github
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes