Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use unique_ptr for CachedData in ContextifyScript::New #33113

Closed
wants to merge 1 commit into from
Closed

src: use unique_ptr for CachedData in ContextifyScript::New #33113

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This closes a memory leak.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Apr 28, 2020
@addaleax addaleax mentioned this pull request Apr 28, 2020
Closed
4 tasks
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31075/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31100/

@addaleax
Copy link
Member Author

Landed in e0ba4b1

@addaleax addaleax closed this Apr 30, 2020
addaleax added a commit that referenced this pull request Apr 30, 2020
@addaleax
src: use unique_ptr for CachedData in ContextifyScript::New
e0ba4b1 
This closes a memory leak.

PR-URL: #33113
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@addaleax addaleax deleted the cached-data-unique branch April 30, 2020 02:51
targos pushed a commit that referenced this pull request May 4, 2020
@addaleax @targos
src: use unique_ptr for CachedData in ContextifyScript::New
de643bc 
This closes a memory leak.

PR-URL: #33113
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@addaleax @targos
src: use unique_ptr for CachedData in ContextifyScript::New
8d3f978 
This closes a memory leak.

PR-URL: #33113
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@addaleax @targos
src: use unique_ptr for CachedData in ContextifyScript::New
ffca498 
This closes a memory leak.

PR-URL: #33113
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @devsnek