Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert test-abort-aliased-buffer-overflow #33196

Merged
merged 2 commits into from May 6, 2020

Conversation

richardlau
Copy link
Member

Revert the test and associated Makefile changes from #31740.

This test is dead code as it is not executed as the abort tests'
AbortTestConfiguration inherits from SimpleTestConfiguration
which does not run tests in subdirectories.

return testpy.AbortTestConfiguration(context, root, 'abort')

class AbortTestConfiguration(SimpleTestConfiguration):

AliasedBuffers do not appear to be intended for direct use by
addons so they should not be tested as such anyway. If a test
is required for #31740 one should be added as part of the
cctest, e.g. as part of test/cctest/test_aliased_buffer.cc.

Refs: #31740

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels May 1, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2020

@richardlau
Copy link
Member Author

Technically #32624 could be reverted as well but I'm inclined to keep it to prevent any inadvertent file adds from contributors switching between branches.

@richardlau richardlau added test Issues and PRs related to the tests. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed windows Issues and PRs related to the Windows platform. labels May 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #33196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33196   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         199      199           
  Lines       66133    66133           
=======================================
  Hits        63974    63974           
  Misses       2159     2159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e951825...9769f84. Read the comment docs.

This reverts commit babeb58.

PR-URL: nodejs#33196
Refs: nodejs#31740
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This reverts commit e08ac09.

PR-URL: nodejs#33196
Refs: nodejs#31740
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau richardlau force-pushed the revertabortaliasedbufferstest branch from 9769f84 to 120d707 Compare May 6, 2020 13:41
@richardlau
Copy link
Member Author

Landed in 86fdaa7...120d707

@richardlau richardlau merged commit 120d707 into nodejs:master May 6, 2020
@richardlau richardlau deleted the revertabortaliasedbufferstest branch May 6, 2020 13:43
codebytere pushed a commit that referenced this pull request May 7, 2020
This reverts commit babeb58.

PR-URL: #33196
Refs: #31740
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request May 7, 2020
This reverts commit e08ac09.

PR-URL: #33196
Refs: #31740
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
This reverts commit babeb58.

PR-URL: #33196
Refs: #31740
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jun 7, 2020
This reverts commit e08ac09.

PR-URL: #33196
Refs: #31740
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants