wasi: fix poll_oneoff memory interface #33250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic.
nodejs-github-bot
added
c++
addaleax
approved these changes
May 5, 2020
|
ping @nodejs/wasi this needs one more sign off in order to land. |
addaleax
added
author ready
gengjiawen
approved these changes
May 8, 2020
|
Landed in bcdbd57 |
addaleax
pushed a commit
that referenced
this pull request
May 8, 2020
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: #33250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
addaleax
removed
author ready
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: #33250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: #33250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASM memory interfacing logic was wrong (particularly around
the size of
__wasi_subscription_t). This commit fixes the logic.(
poll_oneoff()is still unimplemented in uvwasi. I tested this with a local development implementation ofpoll_oneoff(). The implementation worked, but nativepoll()doesn't work well cross platform, so I'm currently trying to rewrite it using libuvuv_poll_ts.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes