Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-dns-idna2008 #33367

Merged
merged 1 commit into from May 15, 2020
Merged

test: fix test-dns-idna2008 #33367

merged 1 commit into from May 15, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented May 12, 2020

The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use family option to force IPv4.

Hide white-space changes in the diff to ignore all the code moved to accommodate line-wrapping at 80 chars.

This failed in node-daily-master last night. I'd like to fast-track. Please 👍 here if you are a Collaborator and agree this could/should be fast-tracked.

00:03:31 not ok 11 internet/test-dns-idna2008
00:03:31   ---
00:03:31   duration_ms: 1.15
00:03:31   severity: fail
00:03:31   exitcode: 1
00:03:31   stack: |-
00:03:31     assert.js:103
00:03:31       throw new AssertionError(obj);
00:03:31       ^
00:03:31     
00:03:31     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
00:03:31     + actual - expected
00:03:31     
00:03:31     + '2a01:238:20a:202:1078::'
00:03:31     - '81.169.145.78'
00:03:31         at GetAddrInfoReqWrap.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/internet/test-dns-idna2008.js:32:10)
00:03:31         at GetAddrInfoReqWrap.callback (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/index.js:364:15)
00:03:31         at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:68:8) {
00:03:31       generatedMessage: true,
00:03:31       code: 'ERR_ASSERTION',
00:03:31       actual: '2a01:238:20a:202:1078::',
00:03:31       expected: '81.169.145.78',
00:03:31       operator: 'strictEqual'
00:03:31     }
00:03:31   ...
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 12, 2020
@Trott
Copy link
Member Author

Trott commented May 12, 2020

Internet tests aren't run in our regular CI so here's a CI for internet tests run the same way we run them in node-daily-master: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14228/

@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 12, 2020
@Trott Trott requested a review from bnoordhuis May 12, 2020 13:48
@Trott
Copy link
Member Author

Trott commented May 14, 2020

@nodejs/dns @nodejs/testing

(Hide whitespace in the diff because a lot of lines were moved to accommodate 80-char wrapping: https://github.com/nodejs/node/pull/33367/files?diff=unified&w=1)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: nodejs#33367
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott merged commit 23a61eb into nodejs:master May 15, 2020
@Trott
Copy link
Member Author

Trott commented May 15, 2020

Landed in 23a61eb

@Trott Trott deleted the idna-again branch May 15, 2020 12:49
codebytere pushed a commit that referenced this pull request May 16, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: #33367
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: #33367
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use `family` option to force IPv4.

PR-URL: nodejs#33367
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants