From fd3dc872e97c0c365efd698848fd1c02e5b73e1e Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Fri, 15 May 2020 09:12:46 +0200 Subject: [PATCH 1/2] src: remove unused misc variable This commit removes the unused 'misc' variable from one of the NodeMainInstance constructors. Another option could be to add a default argument to SetIsolateMiscHandlers but I'd like to hear what others think about that first. --- src/node_main_instance.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/node_main_instance.cc b/src/node_main_instance.cc index 033ab56188bfee..8ba861a32f5246 100644 --- a/src/node_main_instance.cc +++ b/src/node_main_instance.cc @@ -39,8 +39,7 @@ NodeMainInstance::NodeMainInstance(Isolate* isolate, isolate_data_ = std::make_unique(isolate_, event_loop, platform, nullptr); - IsolateSettings misc; - SetIsolateMiscHandlers(isolate_, misc); + SetIsolateMiscHandlers(isolate_, {}); } std::unique_ptr NodeMainInstance::Create( From 762c762212e33f20f85fe8c55443098fb4676923 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Fri, 15 May 2020 10:08:02 +0200 Subject: [PATCH 2/2] src: remove unused IsolateSettings variable --- src/node_main_instance.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/node_main_instance.cc b/src/node_main_instance.cc index 8ba861a32f5246..e9cef5fc002284 100644 --- a/src/node_main_instance.cc +++ b/src/node_main_instance.cc @@ -190,8 +190,7 @@ NodeMainInstance::CreateMainEnvironment(int* exit_code) { context = Context::FromSnapshot(isolate_, kNodeContextIndex).ToLocalChecked(); InitializeContextRuntime(context); - IsolateSettings s; - SetIsolateErrorHandlers(isolate_, s); + SetIsolateErrorHandlers(isolate_, {}); } else { context = NewContext(isolate_); }