From 3a8871e7dca51e5ec0d3ab7bdd61e805d09b1499 Mon Sep 17 00:00:00 2001 From: Sourav Shaw Date: Fri, 22 May 2020 18:10:14 +0530 Subject: [PATCH 1/2] Update events.md Since the section refers to EventEmitter, instances in the example should be created of the same class EventEmitter. --- doc/api/events.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/events.md b/doc/api/events.md index a30e2abb01353c..03a6a243f38ee2 100644 --- a/doc/api/events.md +++ b/doc/api/events.md @@ -266,7 +266,7 @@ but important side effect: any *additional* listeners registered to the same listener that is in the process of being added. ```js -const myEmitter = new MyEmitter(); +const myEmitter = new EventEmitter(); // Only do this once so we don't loop forever myEmitter.once('newListener', (event, listener) => { if (event === 'event') { @@ -315,7 +315,7 @@ A class method that returns the number of listeners for the given `eventName` registered on the given `emitter`. ```js -const myEmitter = new MyEmitter(); +const myEmitter = new EventEmitter(); myEmitter.on('event', () => {}); myEmitter.on('event', () => {}); console.log(EventEmitter.listenerCount(myEmitter, 'event')); From 30ea10726d0aff53e033744513c301894692fbf3 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Fri, 3 Jul 2020 13:41:23 -0700 Subject: [PATCH 2/2] [Squash] fixup Co-authored-by: Ruben Bridgewater --- doc/api/events.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/api/events.md b/doc/api/events.md index 03a6a243f38ee2..a7843e0fd37f3c 100644 --- a/doc/api/events.md +++ b/doc/api/events.md @@ -266,7 +266,9 @@ but important side effect: any *additional* listeners registered to the same listener that is in the process of being added. ```js -const myEmitter = new EventEmitter(); +class MyEmitter extends EventEmitter {} + +const myEmitter = new MyEmitter(); // Only do this once so we don't loop forever myEmitter.once('newListener', (event, listener) => { if (event === 'event') {