Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document changes for */promises alias modules #34002

Closed
wants to merge 1 commit into from

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 21, 2020

Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 21, 2020
doc/api/fs.md Outdated Show resolved Hide resolved
doc/api/dns.md Outdated Show resolved Hide resolved
@shisama
Copy link
Contributor

shisama commented Jun 22, 2020

Is this semver-major as well as #32953?

@Trott
Copy link
Member

Trott commented Jun 24, 2020

Is this semver-major as well as #32953?

This appears to add metadata to the documentation. I don't think that can be semver-major, but maybe there's something I'm failing to consider.

@ljharb
Copy link
Member

ljharb commented Jun 24, 2020

It certainly shouldn’t land anywhere the actual change it’s documenting hasn’t landed.

@Trott
Copy link
Member

Trott commented Jun 24, 2020

It certainly shouldn’t land anywhere the actual change it’s documenting hasn’t landed.

The relevant changes landed in the 10.x days, so I think we're good to land it in all supported branches (14, 12, 10).

doc/api/dns.md Outdated Show resolved Hide resolved
jasnell pushed a commit that referenced this pull request Jun 25, 2020
Refs: #31553
Refs: #32953

PR-URL: #34001
Refs: #34002
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ExE-Boss ExE-Boss mentioned this pull request Jun 25, 2020
4 tasks
ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Jun 27, 2020
@ExE-Boss ExE-Boss requested a review from a team as a code owner August 10, 2020 16:06
ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Oct 6, 2020
@ExE-Boss ExE-Boss requested review from ljharb and Trott and removed request for a team October 12, 2020 17:19
@ljharb
Copy link
Member

ljharb commented Oct 12, 2020

LGTM

nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2020
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002
Refs: #34055

PR-URL: #34962
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
aduh95 pushed a commit that referenced this pull request Oct 20, 2020
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002

PR-URL: #34055
Refs: #34962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@ExE-Boss ExE-Boss force-pushed the doc/api/promises branch 2 times, most recently from 43387b5 to e1f6257 Compare October 21, 2020 11:04
Fixes: nodejs#35740

Refs: nodejs#31553
Refs: nodejs#32953
Refs: nodejs#33991
Refs: nodejs#34001
Refs: nodejs#34055
Refs: nodejs#34962

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
@ExE-Boss ExE-Boss requested a review from Trott October 24, 2020 13:39
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/34002
✔  Done loading data for nodejs/node/pull/34002
----------------------------------- PR info ------------------------------------
Title      doc: document changes for `*/promises` alias modules (#34002)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ExE-Boss:doc/api/promises -> nodejs:master
Labels     author ready, backport-requested-v12.x, backport-requested-v14.x, doc
Commits    1
 - doc: document changes for `*/promises` alias modules
Committers 1
 - ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/34002
Fixes: https://github.com/nodejs/node/issues/35740
Refs: https://github.com/nodejs/node/pull/31553
Refs: https://github.com/nodejs/node/pull/32953
Refs: https://github.com/nodejs/node/pull/33991
Refs: https://github.com/nodejs/node/pull/34001
Refs: https://github.com/nodejs/node/pull/34055
Refs: https://github.com/nodejs/node/pull/34962
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Masashi Hirano 
Reviewed-By: Pranshu Srivastava 
Reviewed-By: Rich Trott 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/34002
Fixes: https://github.com/nodejs/node/issues/35740
Refs: https://github.com/nodejs/node/pull/31553
Refs: https://github.com/nodejs/node/pull/32953
Refs: https://github.com/nodejs/node/pull/33991
Refs: https://github.com/nodejs/node/pull/34001
Refs: https://github.com/nodejs/node/pull/34055
Refs: https://github.com/nodejs/node/pull/34962
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Masashi Hirano 
Reviewed-By: Pranshu Srivastava 
Reviewed-By: Rich Trott 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - doc: document changes for `*/promises` alias modules
   ✖  GitHub CI is still running
   ℹ  Doc-only changes
   ℹ  This PR was created on Sun, 21 Jun 2020 13:24:57 GMT
   ✔  Approvals: 6
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/34002#pullrequestreview-434903938
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34002#pullrequestreview-434999352
   ✔  - Masashi Hirano (@shisama): https://github.com/nodejs/node/pull/34002#pullrequestreview-435064239
   ✔  - Pranshu Srivastava (@rexagod): https://github.com/nodejs/node/pull/34002#pullrequestreview-435078297
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/34002#pullrequestreview-514782300
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/34002#pullrequestreview-516278221
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/325974420

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 24, 2020
@ExE-Boss
Copy link
Contributor Author

@aduh95 There’s a good to fair chance that the commit queue might fail because the latest commit is slightly newer than your latest review, since I added information about #33991.

@ExE-Boss ExE-Boss requested a review from aduh95 October 24, 2020 13:43
@ExE-Boss
Copy link
Contributor Author

The GitHub CI tests have now finished, although test‑macOS/test‑macOS‑with‑quic has timed out.

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 25, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2020
@github-actions
Copy link
Contributor

Landed in 3e10ce3...1d5b91d

@github-actions github-actions bot closed this Oct 25, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 25, 2020
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ExE-Boss ExE-Boss deleted the doc/api/promises branch October 25, 2020 10:43
targos pushed a commit that referenced this pull request Nov 3, 2020
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
codebytere pushed a commit that referenced this pull request Nov 22, 2020
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002
Refs: #34055

PR-URL: #34962
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
codebytere pushed a commit that referenced this pull request Nov 22, 2020
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002

PR-URL: #34055
Refs: #34962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos targos removed backport-requested-v14.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 16, 2021
targos pushed a commit that referenced this pull request May 16, 2021
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fs.md
10 participants