Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: add tests for function declarations using [[DefineOwnProperty]] #34032

Closed
wants to merge 1 commit into from
Closed

vm: add tests for function declarations using [[DefineOwnProperty]] #34032

wants to merge 1 commit into from

Conversation

ExE-Boss
Copy link
Contributor

Refs: #31808

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

review?(@devsnek)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 23, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32242/

This was referenced Jul 8, 2020
Open
Open
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32330/

addaleax pushed a commit that referenced this pull request Jul 15, 2020
@ExE-Boss @addaleax
vm: add tests for function declarations using [[DefineOwnProperty]]
9ae8491 
Refs: #31808

PR-URL: #34032
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@addaleax
Copy link
Member

Landed in 9ae8491

@addaleax addaleax closed this Jul 15, 2020
@ExE-Boss ExE-Boss deleted the test/issue-31808 branch July 16, 2020 00:56
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@ExE-Boss @cjihrig
vm: add tests for function declarations using [[DefineOwnProperty]]
f1578e4 
Refs: #31808

PR-URL: #34032
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@ExE-Boss @MylesBorins
vm: add tests for function declarations using [[DefineOwnProperty]]
c9b652f 
Refs: #31808

PR-URL: #34032
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@ExE-Boss @addaleax
vm: add tests for function declarations using [[DefineOwnProperty]]
981d512 
Refs: #31808

PR-URL: #34032
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@ExE-Boss @addaleax
vm: add tests for function declarations using [[DefineOwnProperty]]
7f51e79 
Refs: #31808

PR-URL: #34032
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ExE-Boss @nodejs-github-bot @addaleax @devsnek