Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify that the ctx argument is optional #34097

Closed
wants to merge 2 commits into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jun 28, 2020

Clarify that the ctx argument of the SNICallback callback is
optional.

Fixes: #34085

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Clarify that the `ctx` argument of the `SNICallback` callback is
optional.

Fixes: nodejs#34085
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jun 28, 2020
@lpinca
Copy link
Member Author

lpinca commented Jun 28, 2020

@nodejs/documentation @nodejs/crypto

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it's impossibly hard to spot.

doc/api/tls.md Outdated Show resolved Hide resolved
jasnell pushed a commit that referenced this pull request Jul 3, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is
optional.

Fixes: #34085

PR-URL: #34097
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jul 3, 2020

LAnded in d2c8b3e

@jasnell jasnell closed this Jul 3, 2020
@lpinca lpinca deleted the gh-34085 branch July 4, 2020 04:42
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is
optional.

Fixes: #34085

PR-URL: #34097
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is
optional.

Fixes: #34085

PR-URL: #34097
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Clarify that the `ctx` argument of the `SNICallback` callback is
optional.

Fixes: #34085

PR-URL: #34097
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: for tls.createServer options, providing ctx to SNICallback cb call is optionary.
7 participants