Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add regression tests for HTTP parser crash #34250

Closed
wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jul 7, 2020

Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102
Refs: #34016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: nodejs#15102
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 7, 2020
@addaleax addaleax added http Issues or PRs related to the http subsystem. dont-land-on-v12.x labels Jul 7, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2020

@bnoordhuis
Copy link
Member

Refs: #15102

Also #34016, (almost) the same issue.

@addaleax
Copy link
Member Author

Landed in 18667ac

addaleax added a commit that referenced this pull request Jul 14, 2020
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax closed this Jul 14, 2020
@addaleax addaleax deleted the test-http-sync-error branch July 14, 2020 13:03
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants