quic: another, another round of quic cleanups #34262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
force-pushed
the
quic-cleanups-5
branch
2 times, most recently
from
d862211
to
e36d749
Compare
Stop the madness. Only you can prevent excessive error code proliferation.
addaleax
approved these changes
Jul 9, 2020
4 tasks
jasnell
added a commit
that referenced
this pull request
Jul 10, 2020
Stop the madness. Only you can prevent excessive error code proliferation. PR-URL: #34262 Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #34262 Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #34262 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"? |
|
@MylesBorins for the time being, none of the quic related PRs/commits should be pulled into any release lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #34247 ... the first 15 commits in this PR are from that one.... that one needs to land first.
This is a WIP, will be adding more commits
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes