diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 76ab1ec8ced2cf..a818bb7d0dbafb 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -11,7 +11,7 @@ env: FLAKY_TESTS: dontcare jobs: - build-windows: + build-windows-with-quic: runs-on: windows-latest steps: - uses: actions/checkout@v2 @@ -24,4 +24,4 @@ jobs: - name: Environment Information run: npx envinfo - name: Build - run: ./vcbuild.bat + run: ./vcbuild.bat experimental-quic diff --git a/.github/workflows/test-linux.yml b/.github/workflows/test-linux.yml index 163f5a1fb7aa90..262ac7e2248ab6 100644 --- a/.github/workflows/test-linux.yml +++ b/.github/workflows/test-linux.yml @@ -25,3 +25,18 @@ jobs: run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn" - name: Test run: make run-ci -j2 V=1 TEST_CI_ARGS="-p dots" + + test-linux-with-quic: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Set up Python ${{ env.PYTHON_VERSION }} + uses: actions/setup-python@v1 + with: + python-version: ${{ env.PYTHON_VERSION }} + - name: Environment Information + run: npx envinfo + - name: Build + run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --experimental-quic" + - name: Test + run: make run-ci -j2 V=1 TEST_CI_ARGS="-p dots" diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index 97074c5238659c..40ffdfc7535a04 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -11,7 +11,7 @@ env: FLAKY_TESTS: dontcare jobs: - test-macOS: + test-macOS-with-quic: runs-on: macos-latest steps: - uses: actions/checkout@v2 @@ -22,6 +22,6 @@ jobs: - name: Environment Information run: npx envinfo - name: Build - run: make build-ci -j8 V=1 CONFIG_FLAGS="--error-on-warn" + run: make build-ci -j8 V=1 CONFIG_FLAGS="--error-on-warn --experimental-quic" - name: Test run: make run-ci -j8 V=1 TEST_CI_ARGS="-p dots" diff --git a/src/quic/node_quic_stream.cc b/src/quic/node_quic_stream.cc index 57b797528a03cb..d63e66988ac2ac 100644 --- a/src/quic/node_quic_stream.cc +++ b/src/quic/node_quic_stream.cc @@ -160,11 +160,11 @@ int QuicStream::DoShutdown(ShutdownWrap* req_wrap) { CHECK_NULL(shutdown_done_); CHECK_NOT_NULL(req_wrap); - shutdown_done_ = std::move([=](int status) { + shutdown_done_ = [=](int status) { CHECK_NOT_NULL(req_wrap); shutdown_done_ = nullptr; req_wrap->Done(status); - }); + }; QuicSession::SendSessionScope send_scope(session());