Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark,test: remove output from readable-async-iterator benchmark #34411

Closed
wants to merge 0 commits into from
Closed

benchmark,test: remove output from readable-async-iterator benchmark #34411

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 17, 2020

Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().

Fixes: #34409

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem. labels Jul 17, 2020
@Trott Trott mentioned this pull request Jul 17, 2020
Closed
@Trott
Copy link
Member Author

Trott commented Jul 17, 2020

cc @ronag @richardlau

@Trott
Copy link
Member Author

Trott commented Jul 17, 2020

Would like to fast-track to unbreak CI. Collaborators, please 👍 here to fast-track.

@Trott Trott requested a review from ronag July 17, 2020 13:04
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jul 17, 2020
@ronag
Copy link
Member

ronag commented Jul 17, 2020

Did I make a mistake somewhere when landing #34035? Shouldn't I have seen this in CI?

@Trott
Copy link
Member Author

Trott commented Jul 17, 2020 •
edited

Did I make a mistake somewhere when landing #34035? Shouldn't I have seen this in CI?

The last CI on the relevant PR was two weeks ago, but we only re-added benchmark tests to CI in the last day or two. You did everything the way you were supposed to. @mmarchini is working on a commit queue and if that works out, it should prevent stuff like this in the future.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32383/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2020
Trott added a commit that referenced this pull request Jul 17, 2020
@Trott
benchmark,test: remove output from readable-async-iterator benchmark
d10c59f 
Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().

Fixes: #34409

PR-URL: #34411
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@Trott Trott closed this Jul 17, 2020
@Trott
Copy link
Member Author

Trott commented Jul 17, 2020

Landed in d10c59f

@Trott Trott deleted the fix-benchmark-test branch July 17, 2020 15:42
@ruyadorno
Copy link
Member

Adding dont-land labels since this builds on top of a semver-major change

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott @cjihrig
benchmark,test: remove output from readable-async-iterator benchmark
70823ef 
Extra output makes test-benchmark-streams fail. Change console.log() to
console.assert().

Fixes: #34409

PR-URL: #34411
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

benchmark/test-benchmark-streams failed
5 participants
@Trott @ronag @nodejs-github-bot @ruyadorno @richardlau