Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use sentence-case in quic.md headers #34453

Closed
wants to merge 0 commits into from
Closed

doc: use sentence-case in quic.md headers #34453

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 20, 2020

For consistency with the rest of our docs and our style guide, use
sentence-case rather than headline-case in the headers in quic.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott requested a review from a team July 20, 2020 23:21
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 20, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 21, 2020
@jasnell jasnell added this to Backlog in QUIC via automation Jul 22, 2020
@jasnell jasnell moved this from Backlog to In Progress in QUIC Jul 22, 2020
Trott added a commit that referenced this pull request Jul 23, 2020
@Trott
doc: use sentence-case in quic.md headers
2c30920 
For consistency with the rest of our docs and our style guide, use
sentence-case rather than headline-case in the headers in quic.md.

PR-URL: #34453
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 23, 2020

Landed in 2c30920

@Trott Trott closed this Jul 23, 2020
QUIC automation moved this from In Progress to Done Jul 23, 2020
@Trott Trott deleted the quic-comply branch July 23, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
No open projects
QUIC
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @jasnell @lpinca @trivikr @ruyadorno @nodejs-github-bot