test: remove superfluous check in pummel/test-timers #34488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Jul 24, 2020
Trott
added
the
author ready
|
@nodejs/testing @nodejs/timers |
Pinging because this could use a second approval. |
This comment has been minimized.
This comment has been minimized.
|
This seems to be a problem with |
rexagod
approved these changes
Jul 24, 2020
|
Sorry, that's my fault, I've been editing the job so that it can also run on IBM i. I've restarted the pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15583/ |
richardlau
approved these changes
Jul 24, 2020
|
Landed in de19224 |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
If setTimeout is not a function, this test and most other tests would fail. There is no need to check it. PR-URL: #34488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
If setTimeout is not a function, this test and most other tests would fail. There is no need to check it. PR-URL: #34488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
If setTimeout is not a function, this test and most other tests would fail. There is no need to check it. PR-URL: #34488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If setTimeout is not a function, this test and most other tests would
fail. There is no need to check it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes