test: add ref comment to tests #34516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Jul 26, 2020
Trott
added
the
author ready
|
Pummel tests don't run in pull-request CI (yet) and it's adding a comment only, so I think GitHub Actions CI is sufficient here. |
BridgeAR
approved these changes
Jul 27, 2020
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814.js. PR-URL: nodejs#34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in fe2a7f0...8598ab8 |
ruyadorno
pushed a commit
that referenced
this pull request
Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ruyadorno
pushed a commit
that referenced
this pull request
Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814_2.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ruyadorno
pushed a commit
that referenced
this pull request
Jul 28, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814_2.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ruyadorno
pushed a commit
that referenced
this pull request
Jul 29, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ruyadorno
pushed a commit
that referenced
this pull request
Jul 29, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814_2.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814_2.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Because the GitHub issue referred to by the test name is in an old repository, put a link to it in a comment in test/pummel/test-regress-GH-814_2.js. PR-URL: #34516 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the GitHub issue referred to by the test names is in an old repository, put a link to it in a comment in each of test/pummel/test-regress-GH-814.js and test/pummel/test-regress-GH-814_2.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes