Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: fix when path is buffer #34540

Closed
wants to merge 3 commits into from
Closed

Conversation

himself65
Copy link
Member

#34514

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Jul 28, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 29, 2020
himself65 added a commit to himself65/node that referenced this pull request Jul 30, 2020
PR-URL: nodejs#34540
Fixes: nodejs#34514
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
@himself65
Copy link
Member Author

Landed in 2c4f30d

@himself65 himself65 closed this Jul 30, 2020
@himself65 himself65 deleted the 20200728-fix branch July 30, 2020 17:39
@codebytere
Copy link
Member

@himself65 could you please manually backport this to v14.x? It caused a new deterministic failure:

=== release test-worker-init-failure ===                                      
Path: parallel/test-worker-init-failure
child stdout: 

child stderr: events.js:291
      throw er; // Unhandled 'error' event
      ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /EMFILE/. Input:

'ENOENT: no such file or directory, uv_cwd'

    at Worker.<anonymous> (/Users/codebytere/Developer/node/test/parallel/test-worker-init-failure.js:38:14)
    at Worker.emit (events.js:314:20)
    at Worker.[kOnErrorMessage] (internal/worker.js:238:10)
    at Worker.[kOnMessage] (internal/worker.js:248:37)
    at MessagePort.<anonymous> (internal/worker.js:167:57)
    at MessagePort.[nodejs.internal.kHybridDispatch] (internal/event_target.js:352:41)
    at MessagePort.exports.emitMessage (internal/per_context/messageport.js:18:26)
    at Worker.[kOnExit] (internal/worker.js:220:5)
    at Worker.<computed>.onexit (internal/worker.js:164:20)
Emitted 'error' event on process instance at:
    at emitUnhandledRejectionOrErr (internal/event_target.js:541:11)
    at MessagePort.[nodejs.internal.kHybridDispatch] (internal/event_target.js:356:9)
    at MessagePort.exports.emitMessage (internal/per_context/messageport.js:18:26)
    at Worker.[kOnExit] (internal/worker.js:220:5)
    at Worker.<computed>.onexit (internal/worker.js:164:20) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'ENOENT: no such file or directory, uv_cwd',
  expected: /EMFILE/,
  operator: 'match'
}
assert.js:103
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 0

    at ChildProcess.<anonymous> (/Users/codebytere/Developer/node/test/parallel/test-worker-init-failure.js:64:12)
    at ChildProcess.<anonymous> (/Users/codebytere/Developer/node/test/common/index.js:363:15)
    at ChildProcess.emit (events.js:314:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}
Command: out/Release/node /Users/codebytere/Developer/node/test/parallel/test-worker-init-failure.js

and i'm not quite sure why.

@MylesBorins MylesBorins mentioned this pull request Aug 11, 2020
@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #34540
Fixes: #34514
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants