quic: multiple TODO cleanups #34655
Closed
quic: multiple TODO cleanups #34655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
jasnell
added
dont-land-on-v14.x
quic
jasnell
force-pushed
the
quic-cleanups-12
branch
from
e275979
to
aace950
Compare
addaleax
approved these changes
Aug 10, 2020
jasnell
added
the
author ready
jasnell
force-pushed
the
quic-cleanups-12
branch
from
aace950
to
a893264
Compare
This was referenced Aug 11, 2020
Trott
approved these changes
Aug 14, 2020
This comment has been minimized.
This comment has been minimized.
This was referenced Aug 15, 2020
jasnell
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/34655 ✔ Done loading data for nodejs/node/pull/34655 ----------------------------------- PR info ------------------------------------ Title quic: multiple TODO cleanups (#34655) Author James M Snell (@jasnell) Branch jasnell:quic-cleanups-12 -> nodejs:master Labels author ready, dont-land-on-v14.x, lib / src, quic, review wanted Commits 3 - quic: resolve minor TODO in QuicSocket - quic: resolve some minor TODOs - quic: limit push check to http/3 Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/34655 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34655 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ Last Full PR CI on 2020-08-14T02:44:54Z: https://ci.nodejs.org/job/node-test-pull-request/32774/ ℹ Last Full Commit CI on 2020-08-07T17:48:29Z: https://ci.nodejs.org/job/node-test-commit/40068/ - Querying data of job/node-test-pull-request/32774/ ✔ Build data downloaded ℹ This PR was created on Fri, 07 Aug 2020 00:12:16 GMT ✔ Approvals: 2 ✔ - Anna Henningsen (@addaleax) (TSC): https://github.com/nodejs/node/pull/34655#pullrequestreview-464341683 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/34655#pullrequestreview-467262442 -------------------------------------------------------------------------------- ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 34655 ✔ Downloaded patch to /home/runner/work/node/node/.ncu/34655/patch -------------------------------------------------------------------------------- Applying: quic: resolve minor TODO in QuicSocket Applying: quic: resolve some minor TODOs Applying: quic: limit push check to http/3 ✔ Patches applied There are 3 commits in the PR Please run the following commands to complete landing |
github-actions
bot
added
the
commit-queue-failed
|
Landed in 8b818cf...344c5e4 |
jasnell
added a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
added a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
added a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
5 tasks
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #34618 to land first (and includes those commits).
Several minor commits that handle some outstanding TODOs in the QUIC impl
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes