Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: fixup setSocket support #34669

Closed
wants to merge 3 commits into from
Closed

quic: fixup setSocket support #34669

wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 7, 2020

Ensures that migration to a new QuicSocket is working.

This depends on #34618 and #34655, both of which should land first. All but the final three commits in this PR are from those earlier PRs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnell jasnell requested a review from a team August 7, 2020 19:30
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 7, 2020
@jasnell jasnell added dont-land-on-v14.x quic Issues and PRs related to the QUIC implementation / HTTP/3. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 7, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 7, 2020 •
edited by jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/32677/
QUIC CI: https://ci.nodejs.org/job/node-test-commit/40077/

@jasnell jasnell added the review wanted PRs that need reviews. label Aug 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 11, 2020 •
edited by jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/32736/ 💚
QUIC CI: https://ci.nodejs.org/job/node-test-commit/40155/ 💚

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2020
This was referenced Aug 11, 2020
Closed
Closed
@jasnell
Copy link
Member Author

jasnell commented Aug 17, 2020

Landed in 344c5e4...c17eaa3

@jasnell jasnell closed this Aug 17, 2020
jasnell added a commit that referenced this pull request Aug 17, 2020
@jasnell
quic: fixup set_socket, fix skipped test
10d5047 
PR-URL: #34669
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Aug 17, 2020
@jasnell
quic: check setSocket natRebinding argument, extend test
442968c 
PR-URL: #34669
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request Aug 17, 2020
@jasnell
quic: add natRebinding argument to docs
c17eaa3 
PR-URL: #34669
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. quic Issues and PRs related to the QUIC implementation / HTTP/3. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasnell @nodejs-github-bot @addaleax