Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: prefer modernize-make-unique #34692

Closed
wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

apply https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@gengjiawen gengjiawen requested a review from a team as a code owner August 9, 2020 13:46
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Aug 9, 2020
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2020
@nodejs-github-bot
Copy link
Collaborator

gengjiawen added a commit that referenced this pull request Aug 11, 2020
PR-URL: #34692
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gengjiawen
Copy link
Member Author

Landed in a747770

@gengjiawen gengjiawen closed this Aug 11, 2020
@gengjiawen gengjiawen deleted the quic_review branch August 11, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants