Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic,timers: use AbortController with correct name/message #34763

Closed
wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Aug 13, 2020

quic: use AbortController with correct name/message

On the web, AbortError is the error name, not the error
message. Change the code to match that.

timers: use AbortController with correct name/message

On the web, AbortError is the error name, not the error
message. Change the code to match that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax requested a review from jasnell August 13, 2020 19:07
@addaleax addaleax requested a review from a team as a code owner August 13, 2020 19:07
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Aug 13, 2020
@aduh95
Copy link
Contributor

aduh95 commented Aug 14, 2020

Typo in the commit message: AbortController is the error name, but in the code the error name is AbortError.

On the web, `AbortError` is the error name, not the error
message. Change the code to match that.
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2020
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Aug 15, 2020

Landed in 9594b54...5d179cb

@Trott Trott closed this Aug 15, 2020
Trott pushed a commit that referenced this pull request Aug 15, 2020
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: #34763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott pushed a commit that referenced this pull request Aug 15, 2020
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: #34763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 15, 2020

Any semver concerns with the timers change?

@addaleax addaleax deleted the abort-error branch August 16, 2020 20:47
@addaleax
Copy link
Member Author

@Trott Given that AbortController has not been released yet, I don’t think so.

targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: nodejs#34763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: nodejs#34763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: nodejs#34763
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2021
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: #34763
Backport-PR-URL: #38386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants