Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: remove unused function arguments #35010

Merged
merged 0 commits into from Sep 4, 2020
Merged

quic: remove unused function arguments #35010

merged 0 commits into from Sep 4, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 1, 2020

validateTransportParams() only takes (and only uses) one argument.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott requested a review from a team September 1, 2020 14:26
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 1, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2020 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/33027/ ✅

@Trott Trott closed this Sep 4, 2020
@Trott
Copy link
Member Author

Trott commented Sep 4, 2020

Landed in e5116b3

@Trott Trott deleted the quic-arg branch September 4, 2020 02:54
@Trott Trott merged commit e5116b3 into nodejs:master Sep 4, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
quic: remove unused function arguments
0de246d 
validateTransportParams() only takes (and only uses) one argument.

PR-URL: nodejs#35010
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Trott @nodejs-github-bot @addaleax @lpinca @trivikr