src: enable wasm trap handler on windows #35033

devsnek · 2020-09-03T15:29:52Z

I don't have a windows so I might've messed this up 😅

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-09-03T17:22:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33039/

src/node.cc

bnoordhuis · 2020-09-05T08:24:15Z

src/node.cc

+    CHECK_NE(AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue),
+             nullptr);


Suggested change

CHECK_NE(AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue),

nullptr);

CHECK_NOT_NULL(AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue));

Although "should be nullptr" is probably not a valid assumption for libnode as the embedder can already have registered exception handlers. I'd change it to this:

// namespace per_process { PVOID old_vectored_exception_handler; } per_process::old_vectored_exception_handler = AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue);

And call RemoveVectoredExceptionHandler() in TearDownOncePerProcess().

what is old_vectored_exception_handler used for? do i pass it to RemoveVectoredExceptionHandler?

src/node.cc

nodejs-github-bot · 2020-09-06T19:18:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33079/

devsnek · 2020-09-07T16:31:20Z

This needs one more TSC approval. cc @nodejs/tsc

github-actions · 2020-09-15T22:18:02Z

Landed in 0577127

PR-URL: #35033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

PR-URL: nodejs#35033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operational on Windows. The changes involve removing the Windows-specific code from the POSIX section and correctly placing it under the WIN32 checks. This fix will ensure that the intended exception handling is active on Windows builds, potentially improving WebAssembly performance. Fixes: nodejs#52404 Refs: nodejs#35033

The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operational on Windows. The changes involve removing the Windows-specific code from the POSIX section and correctly placing it under the WIN32 check. This fix will ensure that the intended exception handling is active on Windows builds. Fixes: nodejs#52404 Refs: nodejs#35033

devsnek requested review from bnoordhuis and addaleax September 3, 2020 15:29

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 3, 2020

devsnek added v8 engine Issues and PRs related to the V8 dependency. semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 3, 2020

addaleax approved these changes Sep 3, 2020

View reviewed changes

devsnek force-pushed the wasm-trap-win branch from d0977d1 to b75a8b0 Compare September 3, 2020 15:34

devsnek added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2020

bnoordhuis reviewed Sep 5, 2020

View reviewed changes

devsnek force-pushed the wasm-trap-win branch from b75a8b0 to f8d3c19 Compare September 5, 2020 15:58

bnoordhuis approved these changes Sep 6, 2020

View reviewed changes

bnoordhuis reviewed Sep 6, 2020

View reviewed changes

src/node.cc Outdated Show resolved Hide resolved

src: enable wasm trap handler on windows

c92a4fe

devsnek force-pushed the wasm-trap-win branch from f8d3c19 to c92a4fe Compare September 6, 2020 14:01

devnexen approved these changes Sep 6, 2020

View reviewed changes

devsnek added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2020

tniessen approved these changes Sep 8, 2020

View reviewed changes

codebytere approved these changes Sep 14, 2020

View reviewed changes

devsnek added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2020

github-actions bot closed this Sep 15, 2020

BethGriggs mentioned this pull request Sep 22, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

thisalihassan mentioned this pull request Apr 15, 2024

src: remove misplaced windows code under posix guard in node.cc #52545

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: enable wasm trap handler on windows #35033

src: enable wasm trap handler on windows #35033

devsnek commented Sep 3, 2020

nodejs-github-bot commented Sep 3, 2020

bnoordhuis Sep 5, 2020

devsnek Sep 5, 2020

nodejs-github-bot commented Sep 6, 2020

devsnek commented Sep 7, 2020 •

edited

github-actions bot commented Sep 15, 2020

		CHECK_NE(AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue),
		nullptr);

	CHECK_NE(AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue),
	nullptr);
	CHECK_NOT_NULL(AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue));

src: enable wasm trap handler on windows #35033

src: enable wasm trap handler on windows #35033

Conversation

devsnek commented Sep 3, 2020

Checklist

nodejs-github-bot commented Sep 3, 2020

bnoordhuis Sep 5, 2020

Choose a reason for hiding this comment

devsnek Sep 5, 2020

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 6, 2020

devsnek commented Sep 7, 2020 • edited

github-actions bot commented Sep 15, 2020

devsnek commented Sep 7, 2020 •

edited