doc: avoid double-while sentence in perf_hooks.md #35078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lundibundi
approved these changes
Sep 7, 2020
DerekNonGeneric
approved these changes
Sep 10, 2020
|
Landed in 4c9b79e |
This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: nodejs#35078 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: #35078 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: #35078 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: #35078 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: nodejs#35078 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves readability, as well as awkward reptition of the word
while with two different meanings in a single sentence.
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while
Checklist