Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: fixed typo in comment #35308

Merged
merged 1 commit into from Sep 25, 2020
Merged

quic: fixed typo in comment #35308

merged 1 commit into from Sep 25, 2020

Conversation

eltociear
Copy link
Contributor

successfull -> successful

Checklist

@eltociear eltociear requested a review from a team September 23, 2020 01:15
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 23, 2020
ItzLevvie
ItzLevvie approved these changes Sep 23, 2020
View reviewed changes
Copy link

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33241/

@eltociear @Trott
quic: fix typo in code comment
109a296 
successfull -> successful

PR-URL: nodejs#35308
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 25, 2020

Landed in 109a296.

Thanks for the contribution! 🎉

@Trott Trott merged commit 109a296 into nodejs:master Sep 25, 2020
@eltociear
Copy link
Contributor Author

@Trott Thank you!

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@eltociear @joesepi
quic: fix typo in code comment
ab8c027 
successfull -> successful

PR-URL: nodejs#35308
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@watilde watilde watilde approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

@himself65 himself65 himself65 approved these changes

@MrHeer MrHeer MrHeer approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@eltociear @nodejs-github-bot @Trott @watilde @richardlau @gireeshpunathil @ItzLevvie @himself65 @MrHeer