Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use Object static properties from primordials #35380

Closed
wants to merge 1 commit into from
Closed

lib: use Object static properties from primordials #35380

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 27, 2020

No description provided.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

targos
targos commented Sep 27, 2020
View reviewed changes
lib/internal/modules/cjs/loader.js
Comment on lines -707 to -708
// Object.prototype and ObjectPrototype refer to our 'primordials' versions
// and are not identical to the versions on the global object.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the case anymore. primordials.Object is the same as global.Object and primordials.ObjectPrototype is the same as global.Object.prototype

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33263/

mcollina
mcollina approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ljharb
Copy link
Member

ljharb commented Sep 27, 2020

LGTM!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2020 •
edited by rickyes

CI: https://ci.nodejs.org/job/node-test-pull-request/33266/ 💚

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/35380
✔  Done loading data for nodejs/node/pull/35380
----------------------------------- PR info ------------------------------------
Title      lib: use Object static properties from primordials (#35380)
Author     Michaël Zasso  (@targos)
Branch     targos:primordials-object -> nodejs:master
Labels     timers
Commits    1
 - lib: use Object static properties from primordials
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/35380
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Daijiro Wachi 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35380
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Daijiro Wachi 
--------------------------------------------------------------------------------
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2020-09-27T19:21:28Z: https://ci.nodejs.org/job/node-test-pull-request/33266/
- Querying data for job/node-test-pull-request/33266/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Sun, 27 Sep 2020 15:42:19 GMT
   ✔  Approvals: 6
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35380#pullrequestreview-497090872
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/35380#pullrequestreview-497101013
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35380#pullrequestreview-497103010
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/35380#pullrequestreview-497109414
   ✔  - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/35380#pullrequestreview-497162346
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35380#pullrequestreview-497191008
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 29, 2020
@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 30, 2020
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 30, 2020
addaleax pushed a commit that referenced this pull request Sep 30, 2020
@targos @addaleax
lib: use Object static properties from primordials
a880653 
PR-URL: #35380
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@addaleax
Copy link
Member

Landed in a880653

@addaleax addaleax closed this Sep 30, 2020
@targos targos deleted the primordials-object branch September 30, 2020 15:56
@BethGriggs
Copy link
Member

This had some conflicts on v14.x, please raise a backport PR if this should land on v14.x.

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
lib: use Object static properties from primordials
72ff509 
PR-URL: nodejs#35380
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos added a commit that referenced this pull request May 16, 2021
@targos
lib: use Object static properties from primordials
e2395b0 
PR-URL: #35380
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@watilde watilde watilde approved these changes

@Flarna Flarna Flarna approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet