doc: add history entry for exports patterns #35410

aduh95 · 2020-09-29T09:11:26Z

Refs: #34718

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-09-29T09:11:30Z

Review requested:

@nodejs/modules

doc/api/packages.md

github-actions · 2020-10-08T22:43:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/35410
✔  Done loading data for nodejs/node/pull/35410
----------------------------------- PR info ------------------------------------
Title      doc: add history entry for exports patterns (#35410)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exports-patterns-history-entry -> nodejs:master
Labels     doc
Commits    3
 - doc: add history entry for exports patterns
 - Node.js 14.13.0
 - Update doc/api/packages.md
Committers 2
 - Antoine du Hamel 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/35410
Refs: https://github.com/nodejs/node/pull/34718
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35410
Refs: https://github.com/nodejs/node/pull/34718
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Doc-only changes
   ℹ  This PR was created on Tue, 29 Sep 2020 09:11:26 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35410#pullrequestreview-500348602
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

github-actions · 2020-10-08T22:53:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/35410 ✔ Done loading data for nodejs/node/pull/35410 ----------------------------------- PR info ------------------------------------ Title doc: add history entry for exports patterns (#35410) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:exports-patterns-history-entry -> nodejs:master Labels commit-queue, doc Commits 3 - doc: add history entry for exports patterns - Node.js 14.13.0 - Update doc/api/packages.md Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/35410 Refs: https://github.com/nodejs/node/pull/34718 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35410 Refs: https://github.com/nodejs/node/pull/34718 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Tue, 29 Sep 2020 09:11:26 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35410#pullrequestreview-500348602 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 35410 From https://github.com/nodejs/node * branch refs/pull/35410/merge -> FETCH_HEAD ✔ Fetched commits as 96c37b33126c..0f54c59f4441 -------------------------------------------------------------------------------- Auto-merging doc/api/packages.md warning: inexact rename detection was skipped due to too many files. warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command. [master 0f54aa01f3] doc: add history entry for exports patterns Author: Antoine du Hamel Date: Tue Sep 29 11:08:55 2020 +0200 1 file changed, 4 insertions(+) Auto-merging doc/api/packages.md warning: inexact rename detection was skipped due to too many files. warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command. [master 742fba0b89] Node.js 14.13.0 Author: Antoine du Hamel Date: Tue Sep 29 16:17:53 2020 -0400 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging doc/api/packages.md warning: inexact rename detection was skipped due to too many files. warning: you may want to set your merge.renamelimit variable to at least 2494 and retry the command. [master 6049e590fc] Update doc/api/packages.md Author: Antoine du Hamel Date: Thu Oct 1 08:28:56 2020 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: add history entry for exports patterns

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 926ab97244] doc: add history entry for exports patterns
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Tue Sep 29 11:08:55 2020 +0200
1 file changed, 4 insertions(+)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Node.js 14.13.0

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 9a6b0191cd] Node.js 14.13.0
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Tue Sep 29 16:17:53 2020 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/packages.md

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 6e3ebd5063] Update doc/api/packages.md
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Thu Oct 1 08:28:56 2020 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.
✔ 926ab97244cdc2c5afeec57cf913e2e90124ab47
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 9a6b0191cd5c03522a04e2b6ed304e52503453bf
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 6e3ebd5063a9a954b43079819a3980faa089f279
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
ℹ Please fix the commit message and try again.

PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

aduh95 · 2020-10-08T23:03:13Z

Landed in 78f2b11.

PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

Backport-PR-URL: #35757 PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 29, 2020

addaleax reviewed Sep 29, 2020

View reviewed changes

doc/api/packages.md Show resolved Hide resolved

aduh95 commented Sep 29, 2020

View reviewed changes

doc/api/packages.md Outdated Show resolved Hide resolved

aduh95 mentioned this pull request Sep 30, 2020

feat: lint YAML comments in md files nodejs/remark-preset-lint-node#139

Merged

aduh95 commented Oct 1, 2020

View reviewed changes

doc/api/packages.md Outdated Show resolved Hide resolved

Trott approved these changes Oct 1, 2020

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2020

github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 8, 2020

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 8, 2020

aduh95 mentioned this pull request Oct 8, 2020

Tracking Issue: commit queue issues and feedback #34770

Open

14 tasks

github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 8, 2020

doc: add history entry for exports patterns

78f2b11

PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

aduh95 force-pushed the exports-patterns-history-entry branch from 0f54c59 to 78f2b11 Compare October 8, 2020 23:02

aduh95 merged commit 78f2b11 into nodejs:master Oct 8, 2020

aduh95 deleted the exports-patterns-history-entry branch October 8, 2020 23:02

BethGriggs pushed a commit that referenced this pull request Oct 13, 2020

doc: add history entry for exports patterns

01c9c59

PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins mentioned this pull request Oct 14, 2020

v14.14.0 proposal #35648

Merged

aduh95 mentioned this pull request Oct 23, 2020

[v12 backport] ESM (named exports for CJS, package.json docs, subpath export patterns, warning removal) #35757

Closed

3 tasks

aduh95 added a commit to aduh95/node that referenced this pull request Oct 23, 2020

doc: add history entry for exports patterns

6c27021

PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request Nov 3, 2020

doc: add history entry for exports patterns

beaa205

Backport-PR-URL: #35757 PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins mentioned this pull request Nov 3, 2020

v12.20.0 proposal #35950

Merged

MylesBorins pushed a commit that referenced this pull request Nov 16, 2020

doc: add history entry for exports patterns

66f8730

Backport-PR-URL: #35757 PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021

doc: add history entry for exports patterns

6602c14

PR-URL: nodejs#35410 Refs: nodejs#34718 Reviewed-By: Rich Trott <rtrott@gmail.com>

targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: add history entry for exports patterns #35410

doc: add history entry for exports patterns #35410

aduh95 commented Sep 29, 2020

nodejs-github-bot commented Sep 29, 2020

github-actions bot commented Oct 8, 2020

github-actions bot commented Oct 8, 2020

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

aduh95 commented Oct 8, 2020

doc: add history entry for exports patterns #35410

doc: add history entry for exports patterns #35410

Conversation

aduh95 commented Sep 29, 2020

Checklist

nodejs-github-bot commented Sep 29, 2020

github-actions bot commented Oct 8, 2020

github-actions bot commented Oct 8, 2020

PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott rtrott@gmail.com

PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott rtrott@gmail.com

PR-URL: #35410 Refs: #34718 Reviewed-By: Rich Trott rtrott@gmail.com

aduh95 commented Oct 8, 2020

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com

PR-URL: #35410
Refs: #34718
Reviewed-By: Rich Trott rtrott@gmail.com