Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: copyedit esm.md #35414

Merged
merged 1 commit into from Oct 2, 2020
Merged

doc: copyedit esm.md #35414

merged 1 commit into from Oct 2, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 29, 2020

This provides a number of minor style adjustments and small corrections
to esm.md text.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Sep 29, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

doc/api/esm.md Outdated Show resolved Hide resolved
This provides a number of minor style adjustments and small corrections
to esm.md text.

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: nodejs#35414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@Trott
Copy link
Member Author

Trott commented Oct 2, 2020

Landed in fa73561

@Trott Trott merged commit fa73561 into nodejs:master Oct 2, 2020
@Trott Trott deleted the esm-copy branch October 2, 2020 11:39
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
This provides a number of minor style adjustments and small corrections
to esm.md text.

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: #35414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
This provides a number of minor style adjustments and small corrections
to esm.md text.

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: #35414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
This provides a number of minor style adjustments and small corrections
to esm.md text.

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: #35414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
This provides a number of minor style adjustments and small corrections
to esm.md text.

Co-authored-by: Guy Bedford <guybedford@gmail.com>

PR-URL: nodejs#35414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants