Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typos in quic.md #35444

Merged
merged 1 commit into from Oct 4, 2020
Merged

doc: fix typos in quic.md #35444

merged 1 commit into from Oct 4, 2020

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 1, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@lpinca lpinca requested a review from a team October 1, 2020 10:59
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Oct 1, 2020
ItzLevvie
ItzLevvie approved these changes Oct 1, 2020
View reviewed changes
Copy link

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasnell
Copy link
Member

jasnell commented Oct 1, 2020

I see no reason for this to have to wait to land. Fast-track?

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 1, 2020
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33321/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33342/

@lpinca
doc: fix typos in quic.md
e6d5af3 
PR-URL: nodejs#35444
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@lpinca lpinca merged commit e6d5af3 into nodejs:master Oct 4, 2020
@lpinca
Copy link
Member Author

lpinca commented Oct 4, 2020

Landed in e6d5af3.

@lpinca lpinca deleted the fix/typos branch October 4, 2020 05:59
@aduh95 aduh95 mentioned this pull request Nov 9, 2020
Closed
1 task
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@lpinca @joesepi
doc: fix typos in quic.md
59c7276 
PR-URL: nodejs#35444
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lpinca @nodejs-github-bot @jasnell @Trott @cjihrig @richardlau @gireeshpunathil @ItzLevvie @trivikr