Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use sentence case for class property #35540

Merged
merged 1 commit into from Oct 9, 2020
Merged

doc: use sentence case for class property #35540

merged 1 commit into from Oct 9, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 7, 2020

Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Oct 7, 2020
@Trott
Copy link
Member Author

Trott commented Oct 7, 2020

Before:

image

After:

image

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33452/

@Trott
doc: use sentence case for class property
936ce85 
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.

PR-URL: nodejs#35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott merged commit 936ce85 into nodejs:master Oct 9, 2020
@Trott
Copy link
Member Author

Trott commented Oct 9, 2020

Landed in 936ce85

@Trott Trott deleted the class-prop-case branch October 9, 2020 13:11
BethGriggs pushed a commit that referenced this pull request Oct 14, 2020
@Trott @BethGriggs
doc: use sentence case for class property
85dc84d 
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.

PR-URL: #35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@Trott @MylesBorins
doc: use sentence case for class property
b3c0f66 
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.

PR-URL: #35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@Trott @MylesBorins
doc: use sentence case for class property
42c4795 
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.

PR-URL: #35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: use sentence case for class property
3d7ee18 
Change the one instance of the Class Property heading in our docs to
Class property to match style with other headers.

PR-URL: nodejs#35540
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Trott @nodejs-github-bot @addaleax @lpinca