Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.0.0-rc.4 #35576

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.0.0-rc.4 #35576

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Member

Fixed a couple of edge cases identified in the last rc

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 9, 2020
@MylesBorins
Copy link
Member Author

As this is an update to the existing npm rc could we please fast-track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33504/

aduh95
aduh95 approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33508/

Trott
Trott approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

gengjiawen pushed a commit that referenced this pull request Oct 10, 2020
@MylesBorins @gengjiawen
deps: upgrade npm to 7.0.0-rc.4
dabc6dd 
PR-URL: #35576
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@gengjiawen
Copy link
Member

Landed in dabc6dd

@gengjiawen gengjiawen closed this Oct 10, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@MylesBorins @joesepi
deps: upgrade npm to 7.0.0-rc.4
2d2905a 
PR-URL: nodejs#35576
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MylesBorins @nodejs-github-bot @gengjiawen @Trott @aduh95