From 2e45fe49a506b630cc0db983864c430892b6ef5a Mon Sep 17 00:00:00 2001 From: "Pooja D.P" Date: Sat, 10 Oct 2020 22:13:10 +0400 Subject: [PATCH 1/3] doc: add new wordings to the API description --- doc/api/process.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/api/process.md b/doc/api/process.md index 119a02aa3d6b87..67b73aa6b31e0a 100644 --- a/doc/api/process.md +++ b/doc/api/process.md @@ -2248,7 +2248,8 @@ exception value itself as its first argument. If such a function is set, the [`'uncaughtException'`][] event will not be emitted. If `--abort-on-uncaught-exception` was passed from the command line or set through [`v8.setFlagsFromString()`][], the process will -not abort. +not abort. This api does not alter the behavior of diagnostic report +configured to on uncaught exceptions. To unset the capture function, `process.setUncaughtExceptionCaptureCallback(null)` may be used. Calling this From 878eb7f01c690118cfb2275923e49b6395e2b6fe Mon Sep 17 00:00:00 2001 From: "Pooja D.P" Date: Sun, 11 Oct 2020 00:01:11 +0400 Subject: [PATCH 2/3] doc: removed trailing whitespaces --- doc/api/process.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/process.md b/doc/api/process.md index 67b73aa6b31e0a..0b507f29db16c9 100644 --- a/doc/api/process.md +++ b/doc/api/process.md @@ -2248,7 +2248,7 @@ exception value itself as its first argument. If such a function is set, the [`'uncaughtException'`][] event will not be emitted. If `--abort-on-uncaught-exception` was passed from the command line or set through [`v8.setFlagsFromString()`][], the process will -not abort. This api does not alter the behavior of diagnostic report +not abort. This api does not alter the behavior of diagnostic report configured to on uncaught exceptions. To unset the capture function, From 93e76bbffc44bd5fece165d7ab804aa682312385 Mon Sep 17 00:00:00 2001 From: "Pooja D.P" Date: Wed, 28 Oct 2020 08:54:56 +0400 Subject: [PATCH 3/3] fixup: address review comments --- doc/api/process.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/process.md b/doc/api/process.md index 0b507f29db16c9..a694508f81d423 100644 --- a/doc/api/process.md +++ b/doc/api/process.md @@ -2248,8 +2248,8 @@ exception value itself as its first argument. If such a function is set, the [`'uncaughtException'`][] event will not be emitted. If `--abort-on-uncaught-exception` was passed from the command line or set through [`v8.setFlagsFromString()`][], the process will -not abort. This api does not alter the behavior of diagnostic report -configured to on uncaught exceptions. +not abort. Actions configured to take place on exceptions such as report +generations will be affected too To unset the capture function, `process.setUncaughtExceptionCaptureCallback(null)` may be used. Calling this