Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reforming process.ppid API docs property in the process.md #35589

Merged
merged 1 commit into from Oct 13, 2020

Conversation

PoojaDurgad
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Oct 10, 2020
@PoojaDurgad PoojaDurgad changed the title Reforming process.ppid() API docs property in the process.md Reforming process.ppid API docs property in the process.md Oct 10, 2020
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also link to the getppid(2) man page? It might be worth giving a resource that describes the behavior when e.g. the original parent process has already terminated.

@@ -1738,7 +1738,8 @@ added:

* {integer}

The `process.ppid` property returns the PID of the current parent process.
The `process.ppid` property returns the PID of the parent of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `process.ppid` property returns the PID of the parent of the
The `process.ppid` property returns the PID of the parent of the

FYI, if you run make lint-md on your changes, it will report these sorts of lint issues in the .md files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott - Thanks for the suggestion. lint issue is fixed. Please have a look.

@PoojaDurgad PoojaDurgad force-pushed the process-ppid branch 2 times, most recently from 7a3095d to 8e8d649 Compare October 12, 2020 06:06
PR-URL: nodejs#35589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott force-pushed the process-ppid branch 2 times, most recently from c072d80 to dcf708d Compare October 13, 2020 10:50
@Trott Trott merged commit dcf708d into nodejs:master Oct 13, 2020
@Trott
Copy link
Member

Trott commented Oct 13, 2020

Landed in dcf708d

MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
PR-URL: #35589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants