Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: bump remark-lint-preset-node to 1.17.1 #35668

Merged
merged 0 commits into from Oct 18, 2020
Merged

tools: bump remark-lint-preset-node to 1.17.1 #35668

merged 0 commits into from Oct 18, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 16, 2020

First commit:

doc: correct order of metadata for deprecation

This is in preparation for updating remark-preset-lint-node to 1.17.1.

Second commit:

tools: bump remark-lint-preset-node to 1.17.1

Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1.

Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 16, 2020
@Trott Trott requested review from bcoe and aduh95 October 16, 2020 04:20
bcoe
bcoe approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the order of deprecation comments one of the things it lints?

This will make the deprecation process much easier 👍

@Trott
Copy link
Member Author

Trott commented Oct 16, 2020

Was the order of deprecation comments one of the things it lints?

Yes. This includes nodejs/remark-preset-lint-node#139 by @aduh95.

@Trott
Copy link
Member Author

Trott commented Oct 18, 2020

Landed in ee85eb9...fbe33aa

Trott added a commit to Trott/io.js that referenced this pull request Oct 18, 2020
@Trott
doc: correct order of metadata for deprecation
89defff 
This is in preparation for updating remark-preset-lint-node to 1.17.1.

PR-URL: nodejs#35668
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott Trott closed this Oct 18, 2020
@Trott Trott merged commit fbe33aa into nodejs:master Oct 18, 2020
@Trott Trott deleted the lint-md-update branch October 18, 2020 11:58
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
tools: bump remark-lint-preset-node to 1.17.1
cbb0a45 
Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1.

Refs: nodejs/remark-preset-lint-node#139

PR-URL: #35668
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
tools: bump remark-lint-preset-node to 1.17.1
d71fd8b 
Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1.

Refs: nodejs/remark-preset-lint-node#139

PR-URL: #35668
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @bcoe @aduh95 @targos @BethGriggs @nodejs-github-bot