deps: V8: set correct V8 version patch number #35732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update to V8 8.6 already included the changes from that version, but it wasn't tagged yet. Having the wrong version in tree breaks node-core-utils.
targos
added
v8 engine
richardlau
approved these changes
Oct 21, 2020
gengjiawen
approved these changes
Oct 21, 2020
Merged
|
👍 to fast-track? (Then it can go out in #35736) |
richardlau
added
the
fast-track
Trott
approved these changes
Oct 21, 2020
github-actions
bot
removed
the
request-ci
BethGriggs
approved these changes
Oct 21, 2020
BethGriggs
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 610c68c...66ab2bd |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 21, 2020
The update to V8 8.6 already included the changes from that version, but it wasn't tagged yet. Having the wrong version in tree breaks node-core-utils. PR-URL: #35732 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 21, 2020
The update to V8 8.6 already included the changes from that version, but it wasn't tagged yet. Having the wrong version in tree breaks node-core-utils. PR-URL: #35732 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to V8 8.6 already included the changes from that version,
but it wasn't tagged yet. Having the wrong version in tree breaks
node-core-utils.