Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 7.12.1 #35799

Merged
merged 2 commits into from Oct 31, 2020
Merged

tools: update ESLint to 7.12.1 #35799

merged 2 commits into from Oct 31, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 25, 2020

Update ESLint to 7.12.1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 25, 2020
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@nodejs-github-bot
Copy link
Collaborator

@cjihrig cjihrig changed the title tools: update ESLint to 7.12.0 tools: update ESLint to 7.12.1 Oct 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2020

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/35799
✔  Done loading data for nodejs/node/pull/35799
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.12.1 (#35799)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     tools
Commits    2
 - tools: update ESLint to 7.12.0
 - tools: update ESLint to 7.12.1
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/35799
Reviewed-By: Rich Trott 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Daijiro Wachi 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35799
Reviewed-By: Rich Trott 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Daijiro Wachi 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: update ESLint to 7.12.0
   ⚠  - tools: update ESLint to 7.12.1
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-10-31T21:09:33Z: https://ci.nodejs.org/job/node-test-pull-request/34003/
- Querying data for job/node-test-pull-request/34003/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Sun, 25 Oct 2020 14:49:54 GMT
   ✔  Approvals: 3
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35799#pullrequestreview-516395615
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/35799#pullrequestreview-516416391
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35799#pullrequestreview-516417296
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/339529805

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 31, 2020
Update ESLint to 7.12.0

PR-URL: nodejs#35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Update ESLint to 7.12.1

PR-URL: nodejs#35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@cjihrig cjihrig merged commit 7ebae13 into nodejs:master Oct 31, 2020
@cjihrig cjihrig deleted the eslint branch October 31, 2020 21:51
targos pushed a commit that referenced this pull request Nov 3, 2020
Update ESLint to 7.12.0

PR-URL: #35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
Update ESLint to 7.12.1

PR-URL: #35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
targos pushed a commit that referenced this pull request May 16, 2021
Update ESLint to 7.12.0

PR-URL: #35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request May 16, 2021
Update ESLint to 7.12.1

PR-URL: #35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Update ESLint to 7.12.0

PR-URL: #35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Update ESLint to 7.12.1

PR-URL: #35799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants