Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: refactor to use more primordials #36024

Closed
wants to merge 1 commit into from
Closed

module: refactor to use more primordials #36024

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 7, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34179/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Landed in a8b9ede...2c77fe1

@github-actions github-actions bot closed this Nov 9, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020
@aduh95 @nodejs-github-bot
module: refactor to use more primordials
2c77fe1 
PR-URL: #36024
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 aduh95 deleted the cjs-primordials branch November 9, 2020 19:07
danielleadams pushed a commit that referenced this pull request Nov 10, 2020
@aduh95 @danielleadams
module: refactor to use more primordials
7a37590 
PR-URL: #36024
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 10, 2020
Merged
targos pushed a commit that referenced this pull request May 16, 2021
@aduh95 @targos
module: refactor to use more primordials
1f38c63 
PR-URL: #36024
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
codebytere added a commit to electron/electron that referenced this pull request May 19, 2021
@codebytere
module: refactor to use more primordials
688927d 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 19, 2021
@codebytere
module: refactor to use more primordials
5af0eb7 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 20, 2021
@codebytere
module: refactor to use more primordials
cad014e 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
c3e574b 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
3f33162 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
715f00f 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request May 31, 2021
@codebytere
module: refactor to use more primordials
4dbf9b6 
nodejs/node#36024
@targos targos mentioned this pull request Jun 6, 2021
Merged
codebytere added a commit to electron/electron that referenced this pull request Jun 8, 2021
@codebytere
module: refactor to use more primordials
bb3b19c 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 8, 2021
@codebytere
module: refactor to use more primordials
3e6f3a5 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 9, 2021
@codebytere
module: refactor to use more primordials
05eb244 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 9, 2021
@codebytere
module: refactor to use more primordials
b51c59f 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 10, 2021
@codebytere
module: refactor to use more primordials
5d8d356 
nodejs/node#36024
codebytere added a commit to electron/electron that referenced this pull request Jun 10, 2021
@codebytere
module: refactor to use more primordials
72b528e 
nodejs/node#36024
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
module: refactor to use more primordials
9e7f166 
PR-URL: #36024
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aduh95 @nodejs-github-bot @Trott @benjamingr