util: fix module inspection & instanceof check during inspect #36178

BridgeAR · 2020-11-19T15:42:37Z

Fixes: #36151
Fixes: #35730
Refs: #35754

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

ExE-Boss · 2020-11-19T16:19:31Z

This PR should also have the following in the PR description and the message of commit d330cd1:

Supersedes and closes #35754

BridgeAR · 2020-11-19T16:20:42Z

@ExE-Boss I added a reference to the issue description but I'd just close the PR manually when this PR lands.

benjamingr

Actual fix LGTM (pending fixed messages changed in tests probably?)

Also - what semverness should this have?

ExE-Boss · 2020-11-19T17:30:58Z

@benjamingr

Also - what semverness should this have?

Probably semver‑patch and be backported to v14.x, given that #33449 wasn’t a semver‑major change either.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#36151

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#35730

Trott · 2020-11-20T13:20:02Z

lib/internal/util/inspect.js

@@ -534,6 +534,14 @@ function getEmptyFormatArray() {
  return [];
 }

+function isInstanceof(object, proto) {
+  try {
+    return object instanceof proto;


TIL: instanceof can throw

nodejs-github-bot · 2020-11-20T13:25:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34482/

guybedford

Thanks so much for fixing this up. Really nice to surface the null prototype too.

nodejs-github-bot · 2020-12-07T10:26:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34812/

ExE-Boss · 2020-12-10T20:10:35Z

The node‑test‑linux‑linked‑debug Jenkins CI build needs restarting.

nodejs-github-bot · 2020-12-10T21:23:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34892/

ExE-Boss · 2020-12-12T17:19:40Z

node‑test‑linux‑linked‑debug failed again.

BridgeAR · 2020-12-12T20:54:19Z

@ExE-Boss the failure is an old run and not properly updated :)

github-actions · 2020-12-12T20:58:06Z

Landed in 738cd60...1e66509

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: #36151 PR-URL: #36178 Fixes: #35730 Refs: #35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: #35730 PR-URL: #36178 Fixes: #36151 Refs: #35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: #36151 PR-URL: #36178 Fixes: #35730 Refs: #35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: #35730 PR-URL: #36178 Fixes: #36151 Refs: #35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Pezmc · 2021-01-27T11:36:49Z

Is this likely to be backported to 14.x LTS? It doesn't seem to be included in 14.15.3 @ExE-Boss

Edit: trying to follow https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md myself!

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#36151 PR-URL: nodejs#36178 Fixes: nodejs#35730 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#35730 PR-URL: nodejs#36178 Fixes: nodejs#36151 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#36151 PR-URL: nodejs#36178 Fixes: nodejs#35730 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#35730 PR-URL: nodejs#36178 Fixes: nodejs#36151 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#36151 PR-URL: nodejs#36178 Fixes: nodejs#35730 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#35730 PR-URL: nodejs#36178 Fixes: nodejs#36151 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#36151 PR-URL: nodejs#36178 Fixes: nodejs#35730 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#35730 PR-URL: nodejs#36178 Fixes: nodejs#36151 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#36151 PR-URL: nodejs#36178 Fixes: nodejs#35730 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#37100 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#35730 PR-URL: nodejs#36178 Fixes: nodejs#36151 Refs: nodejs#35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Backport-PR-URL: #37100 PR-URL: #36178 Fixes: #35730 Fixes: #36151 Refs: #35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 19, 2020

benjamingr approved these changes Nov 19, 2020

View reviewed changes

BridgeAR force-pushed the 36151/fix-module-inspection branch from d330cd1 to 3199002 Compare November 19, 2020 19:15

BridgeAR requested a review from guybedford November 19, 2020 19:17

BridgeAR added 2 commits November 20, 2020 00:35

util: fix module prefixes during inspection

6bf0b56

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#36151

util: fix instanceof checks with null prototypes during inspection

cb9eec9

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Fixes: nodejs#35730

BridgeAR force-pushed the 36151/fix-module-inspection branch from 3199002 to cb9eec9 Compare November 19, 2020 23:35

BridgeAR added the needs-ci PRs that need a full CI run. label Nov 20, 2020

Trott reviewed Nov 20, 2020

View reviewed changes

Trott approved these changes Nov 20, 2020

View reviewed changes

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2020

guybedford approved these changes Nov 20, 2020

View reviewed changes

jasnell approved these changes Nov 22, 2020

View reviewed changes

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Dec 7, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020

BridgeAR added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2020

github-actions bot closed this Dec 12, 2020

ExE-Boss mentioned this pull request Dec 12, 2020

util: remove instance check on empty object #35754

Closed

3 tasks

targos mentioned this pull request Dec 22, 2020

v15.5.0 release proposal #36597

Merged

Pezmc mentioned this pull request Jan 27, 2021

[v14.x backport] util: fix module inspection & instanceof check during inspect #37100

Closed

BethGriggs mentioned this pull request Feb 5, 2021

v14.15.5 proposal #37074

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: fix module inspection & instanceof check during inspect #36178

util: fix module inspection & instanceof check during inspect #36178

BridgeAR commented Nov 19, 2020 •

edited

ExE-Boss commented Nov 19, 2020 •

edited

BridgeAR commented Nov 19, 2020

benjamingr left a comment

ExE-Boss commented Nov 19, 2020

Trott Nov 20, 2020

nodejs-github-bot commented Nov 20, 2020

guybedford left a comment

nodejs-github-bot commented Dec 7, 2020

ExE-Boss commented Dec 10, 2020

nodejs-github-bot commented Dec 10, 2020

ExE-Boss commented Dec 12, 2020

BridgeAR commented Dec 12, 2020

github-actions bot commented Dec 12, 2020

Pezmc commented Jan 27, 2021 •

edited

util: fix module inspection & instanceof check during inspect #36178

util: fix module inspection & instanceof check during inspect #36178

Conversation

BridgeAR commented Nov 19, 2020 • edited

Checklist

ExE-Boss commented Nov 19, 2020 • edited

BridgeAR commented Nov 19, 2020

benjamingr left a comment

Choose a reason for hiding this comment

ExE-Boss commented Nov 19, 2020

Trott Nov 20, 2020

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 20, 2020

guybedford left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 7, 2020

ExE-Boss commented Dec 10, 2020

nodejs-github-bot commented Dec 10, 2020

ExE-Boss commented Dec 12, 2020

BridgeAR commented Dec 12, 2020

github-actions bot commented Dec 12, 2020

Pezmc commented Jan 27, 2021 • edited

BridgeAR commented Nov 19, 2020 •

edited

ExE-Boss commented Nov 19, 2020 •

edited

Pezmc commented Jan 27, 2021 •

edited